system tests: search: delete documents individually #784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
That's backwards right ? You can't currently delete indexes, and you
accomplish the same result by deleting all of the documents in the index.
Right ?
|
|
Yep, thanks. Will fix that in the first post. |
| @@ -67,12 +56,8 @@ describe('Search', function() { | |||
| var INDEX_NAME = generateIndexName(); | |||
| var index = search.index(INDEX_NAME); | |||
|
|
|||
| before(function(done) { | |||
| deleteAllDocuments(done); | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
callmehiphop
added a commit
that referenced
this pull request
Aug 6, 2015
system tests: search: delete documents individually
|
Travis will be so happy! (I hope!) |
|
@stephenplusplus We are trying to follow your work on Search, as we're about to start on it for the Ruby lib. Do you think you could create a |
|
@quartzmo sure, I found a few: https://github.com/GoogleCloudPlatform/gcloud-node/issues?q=label%3Asearch+is%3Aclosed I don't think we've had that many. Let me know if any questions come up. |
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Jan 10, 2023
samples: pull in latest typeless bot, clean up some comments Source-Link: https://togithub.com/googleapis/synthtool/commit/0a68e568b6911b60bb6fd452eba4848b176031d8 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:5b05f26103855c3a15433141389c478d1d3fe088fb5d4e3217c4793f6b3f245e
sofisl
pushed a commit
that referenced
this pull request
Jan 10, 2023
🤖 I have created a release *beep* *boop* --- ## [4.3.0](https://togithub.com/googleapis/nodejs-dlp/compare/v4.2.0...v4.3.0) (2023-01-06) ### Features * ExcludeByHotword added as an ExclusionRule type, NEW_ZEALAND added as a LocationCategory value ([5b54b2e](https://togithub.com/googleapis/nodejs-dlp/commit/5b54b2e9c63acee3022089d9fb94d8b1907c1eb2)) ### Bug Fixes * Deprecate extra field to avoid confusion ([#777](https://togithub.com/googleapis/nodejs-dlp/issues/777)) ([f6a7ebd](https://togithub.com/googleapis/nodejs-dlp/commit/f6a7ebde9f78440600ac178a568e3fe79ccfadc2)) * **deps:** Use google-gax v3.5.2 ([#781](https://togithub.com/googleapis/nodejs-dlp/issues/781)) ([3601ed8](https://togithub.com/googleapis/nodejs-dlp/commit/3601ed84fa97958ca52bdc8d5620317f1a4a1de5)) * Regenerated protos JS and TS definitions ([#784](https://togithub.com/googleapis/nodejs-dlp/issues/784)) ([fa109f0](https://togithub.com/googleapis/nodejs-dlp/commit/fa109f05c3a29473a330e96b20e89480fb89496e)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Jan 17, 2023
sofisl
pushed a commit
that referenced
this pull request
Jan 24, 2023
* fix: failing tests for LRO check methods Updated gapic-generator-typescript to v2.1.1. Committer: @alexander-fenster PiperOrigin-RevId: 387841814 Source-Link: googleapis/googleapis@f973532 Source-Link: googleapis/googleapis-gen@acb489d * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/master/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
sofisl
pushed a commit
that referenced
this pull request
Jan 24, 2023
🤖 I have created a release \*beep\* \*boop\* --- ### [4.5.6](https://www.github.com/googleapis/nodejs-speech/compare/v4.5.5...v4.5.6) (2021-08-02) ### Bug Fixes * failing tests for LRO check methods ([#784](https://www.github.com/googleapis/nodejs-speech/issues/784)) ([08e4276](https://www.github.com/googleapis/nodejs-speech/commit/08e4276a39a74a45300041278dc3c63602971c10)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
sofisl
pushed a commit
that referenced
this pull request
Jan 25, 2023
* fix: failing tests for LRO check methods Updated gapic-generator-typescript to v2.1.1. Committer: @alexander-fenster PiperOrigin-RevId: 387841814 Source-Link: googleapis/googleapis@f973532 Source-Link: googleapis/googleapis-gen@acb489d * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/master/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
sofisl
pushed a commit
that referenced
this pull request
Jan 25, 2023
🤖 I have created a release \*beep\* \*boop\* --- ### [4.5.6](https://www.github.com/googleapis/nodejs-speech/compare/v4.5.5...v4.5.6) (2021-08-02) ### Bug Fixes * failing tests for LRO check methods ([#784](https://www.github.com/googleapis/nodejs-speech/issues/784)) ([08e4276](https://www.github.com/googleapis/nodejs-speech/commit/08e4276a39a74a45300041278dc3c63602971c10)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RE: #775 (comment)
The Search API doesn't allow indexes to be deleted. Instead, you can delete all of the documents within them. That's what we were doing previously, but as the amount of created Documents grows, it's taking an excessive amount of time to fetch, then iteratively delete each one that exists.
This PR changes the tests to create/delete a document, instead of letting the before/after hooks handle it the old way.