Make PubSub subscriber Scheduler inherit from ABC (#7690)

googleapis · Apr 24, 2019 · 7755867 · 7755867
1 parent ec14bbd
commit 7755867
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/pubsub/google/cloud/pubsub_v1/subscriber/scheduler.py b/pubsub/google/cloud/pubsub_v1/subscriber/scheduler.py
@@ -73,7 +73,7 @@ def _make_default_thread_pool_executor():
  return concurrent.futures.ThreadPoolExecutor(max_workers=10, **executor_kwargs)
 
 
-class ThreadScheduler(object):
+class ThreadScheduler(Scheduler):
  """A thread pool-based scheduler.
 
  This scheduler is useful in typical I/O-bound message processing.

diff --git a/pubsub/tests/unit/pubsub_v1/subscriber/test_scheduler.py b/pubsub/tests/unit/pubsub_v1/subscriber/test_scheduler.py
@@ -21,6 +21,10 @@
 from google.cloud.pubsub_v1.subscriber import scheduler
 
 
+def test_subclasses_base_abc():
+ assert issubclass(scheduler.ThreadScheduler, scheduler.Scheduler)
+
+
 def test_constructor_defaults():
  scheduler_ = scheduler.ThreadScheduler()