Adding check that **all** setup.py README's are valid RST. (#3318)

* Adding check that **all** setup.py README's are valid RST.

Follow up to #3316. Fixes #2446.

* Fixing duplicate reference in Logging README.

* Fixing duplicate reference in Monitoring README.

bigquery/nox.py

@@ -77,6 +77,15 @@ def lint(session):
  session.run('flake8', 'google/cloud/bigquery')
 
 
+@nox.session
+def lint_setup_py(session):
+ """Verify that setup.py is valid (including RST check)."""
+ session.interpreter = 'python3.6'
+ session.install('docutils', 'Pygments')
+ session.run(
+ 'python', 'setup.py', 'check', '--restructuredtext', '--strict')
+
+
 @nox.session
 def cover(session):
  """Run the final coverage report.

bigtable/nox.py

@@ -76,6 +76,15 @@ def lint(session):
  session.run('flake8', 'google/cloud/bigtable')
 
 
+@nox.session
+def lint_setup_py(session):
+ """Verify that setup.py is valid (including RST check)."""
+ session.interpreter = 'python3.6'
+ session.install('docutils', 'Pygments')
+ session.run(
+ 'python', 'setup.py', 'check', '--restructuredtext', '--strict')
+
+
 @nox.session
 def cover(session):
  """Run the final coverage report.

core/nox.py

@@ -53,6 +53,15 @@ def lint(session):
  session.run('flake8', 'google/cloud/core')
 
 
+@nox.session
+def lint_setup_py(session):
+ """Verify that setup.py is valid (including RST check)."""
+ session.interpreter = 'python3.6'
+ session.install('docutils', 'Pygments')
+ session.run(
+ 'python', 'setup.py', 'check', '--restructuredtext', '--strict')
+
+
 @nox.session
 def cover(session):
  """Run the final coverage report.

dns/nox.py

@@ -55,6 +55,15 @@ def lint(session):
  session.run('flake8', 'google/cloud/dns')
 
 
+@nox.session
+def lint_setup_py(session):
+ """Verify that setup.py is valid (including RST check)."""
+ session.interpreter = 'python3.6'
+ session.install('docutils', 'Pygments')
+ session.run(
+ 'python', 'setup.py', 'check', '--restructuredtext', '--strict')
+
+
 @nox.session
 def cover(session):
  """Run the final coverage report.

error_reporting/nox.py

@@ -55,6 +55,15 @@ def lint(session):
  session.run('flake8', 'google/cloud/error_reporting')
 
 
+@nox.session
+def lint_setup_py(session):
+ """Verify that setup.py is valid (including RST check)."""
+ session.interpreter = 'python3.6'
+ session.install('docutils', 'Pygments')
+ session.run(
+ 'python', 'setup.py', 'check', '--restructuredtext', '--strict')
+
+
 @nox.session
 def cover(session):
  """Run the final coverage report.

language/nox.py

@@ -77,6 +77,15 @@ def lint(session):
  session.run('flake8', 'google/cloud/language')
 
 
+@nox.session
+def lint_setup_py(session):
+ """Verify that setup.py is valid (including RST check)."""
+ session.interpreter = 'python3.6'
+ session.install('docutils', 'Pygments')
+ session.run(
+ 'python', 'setup.py', 'check', '--restructuredtext', '--strict')
+
+
 @nox.session
 def cover(session):
  """Run the final coverage report.

logging/README.rst

@@ -35,7 +35,6 @@ Using the API
 `Stackdriver Logging`_ API (`Logging API docs`_) allows you to store, search,
 analyze, monitor, and alert on log data and events from Google Cloud Platform.
 
-.. _Stackdriver Logging: https://cloud.google.com/logging/
 .. _Logging API docs: https://cloud.google.com/logging/docs/
 
 .. code:: python

logging/nox.py

@@ -79,6 +79,15 @@ def lint(session):
  session.run('flake8', 'google/cloud/logging')
 
 
+@nox.session
+def lint_setup_py(session):
+ """Verify that setup.py is valid (including RST check)."""
+ session.interpreter = 'python3.6'
+ session.install('docutils', 'Pygments')
+ session.run(
+ 'python', 'setup.py', 'check', '--restructuredtext', '--strict')
+
+
 @nox.session
 def cover(session):
  """Run the final coverage report.

monitoring/README.rst

@@ -42,7 +42,6 @@ insights via dashboards, charts, and alerts.
 This package currently supports all Monitoring API operations other than
 writing custom metrics.
 
-.. _Stackdriver Monitoring: https://cloud.google.com/monitoring/
 .. _Monitoring API docs: https://cloud.google.com/monitoring/api/ref_v3/rest/
 
 List available metric types:

monitoring/nox.py

@@ -77,6 +77,15 @@ def lint(session):
  session.run('flake8', 'google/cloud/monitoring')
 
 
+@nox.session
+def lint_setup_py(session):
+ """Verify that setup.py is valid (including RST check)."""
+ session.interpreter = 'python3.6'
+ session.install('docutils', 'Pygments')
+ session.run(
+ 'python', 'setup.py', 'check', '--restructuredtext', '--strict')
+
+
 @nox.session
 def cover(session):
  """Run the final coverage report.

nox.py

@@ -37,3 +37,12 @@ def docs(session):
 
  # Build the docs!
  session.run('bash', './test_utils/scripts/update_docs.sh')
+
+
+@nox.session
+def lint_setup_py(session):
+ """Verify that setup.py is valid (including RST check)."""
+ session.interpreter = 'python3.6'
+ session.install('docutils', 'Pygments')
+ session.run(
+ 'python', 'setup.py', 'check', '--restructuredtext', '--strict')

pubsub/nox.py

@@ -77,6 +77,15 @@ def lint(session):
  session.run('flake8', 'google/cloud/pubsub')
 
 
+@nox.session
+def lint_setup_py(session):
+ """Verify that setup.py is valid (including RST check)."""
+ session.interpreter = 'python3.6'
+ session.install('docutils', 'Pygments')
+ session.run(
+ 'python', 'setup.py', 'check', '--restructuredtext', '--strict')
+
+
 @nox.session
 def cover(session):
  """Run the final coverage report.

resource_manager/nox.py

@@ -55,6 +55,15 @@ def lint(session):
  session.run('flake8', 'google/cloud/resource_manager')
 
 
+@nox.session
+def lint_setup_py(session):
+ """Verify that setup.py is valid (including RST check)."""
+ session.interpreter = 'python3.6'
+ session.install('docutils', 'Pygments')
+ session.run(
+ 'python', 'setup.py', 'check', '--restructuredtext', '--strict')
+
+
 @nox.session
 def cover(session):
  """Run the final coverage report.

runtimeconfig/nox.py

@@ -55,6 +55,15 @@ def lint(session):
  session.run('flake8', 'google/cloud/runtimeconfig')
 
 
+@nox.session
+def lint_setup_py(session):
+ """Verify that setup.py is valid (including RST check)."""
+ session.interpreter = 'python3.6'
+ session.install('docutils', 'Pygments')
+ session.run(
+ 'python', 'setup.py', 'check', '--restructuredtext', '--strict')
+
+
 @nox.session
 def cover(session):
  """Run the final coverage report.

spanner/nox.py

@@ -77,6 +77,15 @@ def lint(session):
  session.run('flake8', 'google/cloud/spanner')
 
 
+@nox.session
+def lint_setup_py(session):
+ """Verify that setup.py is valid (including RST check)."""
+ session.interpreter = 'python3.6'
+ session.install('docutils', 'Pygments')
+ session.run(
+ 'python', 'setup.py', 'check', '--restructuredtext', '--strict')
+
+
 @nox.session
 def cover(session):
  """Run the final coverage report.

speech/nox.py

@@ -77,6 +77,15 @@ def lint(session):
  session.run('flake8', 'google/cloud/speech')
 
 
+@nox.session
+def lint_setup_py(session):
+ """Verify that setup.py is valid (including RST check)."""
+ session.interpreter = 'python3.6'
+ session.install('docutils', 'Pygments')
+ session.run(
+ 'python', 'setup.py', 'check', '--restructuredtext', '--strict')
+
+
 @nox.session
 def cover(session):
  """Run the final coverage report.

storage/nox.py

@@ -77,6 +77,15 @@ def lint(session):
  session.run('flake8', 'google/cloud/storage')
 
 
+@nox.session
+def lint_setup_py(session):
+ """Verify that setup.py is valid (including RST check)."""
+ session.interpreter = 'python3.6'
+ session.install('docutils', 'Pygments')
+ session.run(
+ 'python', 'setup.py', 'check', '--restructuredtext', '--strict')
+
+
 @nox.session
 def cover(session):
  """Run the final coverage report.

translate/nox.py

@@ -77,6 +77,15 @@ def lint(session):
  session.run('flake8', 'google/cloud/translate')
 
 
+@nox.session
+def lint_setup_py(session):
+ """Verify that setup.py is valid (including RST check)."""
+ session.interpreter = 'python3.6'
+ session.install('docutils', 'Pygments')
+ session.run(
+ 'python', 'setup.py', 'check', '--restructuredtext', '--strict')
+
+
 @nox.session
 def cover(session):
  """Run the final coverage report.

vision/nox.py

@@ -77,6 +77,15 @@ def lint(session):
  session.run('flake8', 'google/cloud/vision')
 
 
+@nox.session
+def lint_setup_py(session):
+ """Verify that setup.py is valid (including RST check)."""
+ session.interpreter = 'python3.6'
+ session.install('docutils', 'Pygments')
+ session.run(
+ 'python', 'setup.py', 'check', '--restructuredtext', '--strict')
+
+
 @nox.session
 def cover(session):
  """Run the final coverage report.