Skip to content

Commit

Permalink
Adds _connection object to bigquery magics context. (#8192)
Browse files Browse the repository at this point in the history
* Adds _connection object to bigquery magics context.

* Moves make_connection to helpers.py and adds unit test for no connection in context.
  • Loading branch information
vimota authored and tswast committed May 31, 2019
1 parent c37afe5 commit 8d9d129
Show file tree
Hide file tree
Showing 4 changed files with 254 additions and 127 deletions.
3 changes: 3 additions & 0 deletions bigquery/google/cloud/bigquery/magics.py
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,7 @@ class Context(object):
def __init__(self):
self._credentials = None
self._project = None
self._connection = None
self._use_bqstorage_api = None

@property
Expand Down Expand Up @@ -363,6 +364,8 @@ def _cell_magic(line, query):

project = args.project or context.project
client = bigquery.Client(project=project, credentials=context.credentials)
if context._connection:
client._connection = context._connection
bqstorage_client = _make_bqstorage_client(
args.use_bqstorage_api or context.use_bqstorage_api, context.credentials
)
Expand Down
24 changes: 24 additions & 0 deletions bigquery/tests/unit/helpers.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
# Copyright 2018 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.


def make_connection(*responses):
import google.cloud.bigquery._http
import mock
from google.cloud.exceptions import NotFound

mock_conn = mock.create_autospec(google.cloud.bigquery._http.Connection)
mock_conn.user_agent = "testing 1.2.3"
mock_conn.api_request.side_effect = list(responses) + [NotFound("miss")]
return mock_conn
Loading

0 comments on commit 8d9d129

Please sign in to comment.