Forward connection w/o interception to 'ACL.save'.

googleapis · May 6, 2015 · ad0557d · ad0557d
1 parent 6dc5c56
commit ad0557d
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 3 deletions.
diff --git a/gcloud/storage/blob.py b/gcloud/storage/blob.py
@@ -521,8 +521,6 @@ def make_public(self, connection=None):
  :param connection: Optional. The connection to use when sending
  requests. If not provided, falls back to default.
  """
- if connection is None:
- connection = self.connection
  self.acl.all().grant_read()
  self.acl.save(connection=connection)
 

diff --git a/gcloud/storage/test_blob.py b/gcloud/storage/test_blob.py
@@ -729,7 +729,7 @@ def test_upload_from_string_w_text(self):
  self.assertEqual(headers['Content-Type'], 'text/plain')
  self.assertEqual(rq[0]['body'], ENCODED)
 
- def test_make_public(self):
+ def test_make_public_w_implicit_ocnnection(self):
  from gcloud.storage.acl import _ACLEntity
  from gcloud.storage._testing import _monkey_defaults
  BLOB_NAME = 'blob-name'