Skip to content

Commit

Permalink
fix(runtimeconfig): update test assertion and core version pins (#10097)
Browse files Browse the repository at this point in the history
* Adjust request params assertion in test (timeout)

* Update version pin for core dependency

Version bump is needed, as timeouts were introduced to API core.
  • Loading branch information
plamut authored Jan 10, 2020
1 parent c25d741 commit b144fbf
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
2 changes: 1 addition & 1 deletion runtimeconfig/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
# 'Development Status :: 5 - Production/Stable'
release_status = 'Development Status :: 3 - Alpha'
dependencies = [
"google-cloud-core >= 1.0.3, < 2.0dev",
"google-cloud-core >= 1.1.0, < 2.0dev",
]
extras = {
}
Expand Down
6 changes: 5 additions & 1 deletion runtimeconfig/tests/unit/test__http.py
Original file line number Diff line number Diff line change
Expand Up @@ -62,5 +62,9 @@ def test_extra_headers(self):
}
expected_uri = conn.build_api_url("/rainbow")
http.request.assert_called_once_with(
data=req_data, headers=expected_headers, method="GET", url=expected_uri
data=req_data,
headers=expected_headers,
method="GET",
url=expected_uri,
timeout=None,
)

0 comments on commit b144fbf

Please sign in to comment.