Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation Issue] Datastore docs don't seem to reference client pattern? #1378

Closed
jgeewax opened this issue Jan 11, 2016 · 3 comments
Closed
Assignees
Labels
api: datastore Issues related to the Datastore API. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@jgeewax
Copy link
Contributor

jgeewax commented Jan 11, 2016

Page Name: datastore-keys
Release: 0.8.0

Looks like a lot of our snippet documentation is out of date since the client pattern changes. Can we go through and "assume" there's a client at the start of each method, and write docs that fit there? Or re-do the snippets so that they work?

/cc @dhermes : I know we have a separate issue for testing the snippets as doctests (and it was stalled due to ... mocking concerns among other things). Figure this is worth a look.

@jgeewax jgeewax added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. api: datastore Issues related to the Datastore API. docs labels Jan 11, 2016
@dhermes
Copy link
Contributor

dhermes commented Jan 11, 2016

For posterity, the referred to issue is #212

@dhermes
Copy link
Contributor

dhermes commented Jan 11, 2016

Also relevant is the discussion in #1141.

@dhermes
Copy link
Contributor

dhermes commented Feb 22, 2016

I think this was settled by #1352, but am double-checking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: datastore Issues related to the Datastore API. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

2 participants