BigQuery dataset.list_tables() fails when the dataset is empty

[evmin]

Good day.

Getting this exception when the BigQuery dataset contains no tables:

  File "/Library/Python/2.7/site-packages/gcloud/bigquery/dataset.py", line 507, in list_tables
    for resource in resp['tables']]
KeyError: 'tables'

Mac OS X El Capitan. gcloud 0.8.0

[dhermes]

Thanks @evmin!

[dhermes]

I reproduced with

>>> from gcloud import bigquery
>>> client = bigquery.Client()
>>> dataset_name = 'foo_bar_baz'
>>> dataset = client.dataset(dataset_name)
>>> if dataset.exists():
...     raise ValueError('Expected a new dataset')
...
>>> dataset.create()
>>> dataset.exists()
True
>>> all_tables, token = dataset.list_tables()
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "gcloud/bigquery/dataset.py", line 553, in list_tables
    for resource in resp['tables']]
KeyError: 'tables'
>>> dataset.delete()
>>>

at 2323e1a

[tseaver]

What is the content of resp at that point? The API docs don't indicate that the tables key is optional. We can defend against it, but shouldn't have to, IMHO.

[dhermes]

@tseaver I sent out a fix for this already.

[tseaver]

Oops, my bad.

[dhermes]

@tseaver Here is the full payload

{
  "etag": "\"AMpOK...\"", 
  "kind": "bigquery#tableList", 
  "totalItems": 0
}

Anything issue there before I merge the fix?

[tseaver]

Nope, I was just "arguing with the ref": like it would have hurt the back-end to send the extra 13 bytes. :(

[dhermes]

Gotcha.