Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider re-enabling GAX bundling for 'Topic.publish' #1911

Closed
tseaver opened this issue Jun 26, 2016 · 7 comments
Closed

Consider re-enabling GAX bundling for 'Topic.publish' #1911

tseaver opened this issue Jun 26, 2016 · 7 comments
Assignees
@yoshi-automation
Labels
api: pubsub Issues related to the Pub/Sub API. grpc type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@tseaver
Copy link
Contributor

tseaver commented Jun 26, 2016

... once a fix is relased for googleapis/gax-python#113

/cc @bjwatson, @geigerj.
@tseaver tseaver added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. api: pubsub Issues related to the Pub/Sub API. labels Jun 26, 2016
@geigerj
Copy link
Contributor

geigerj commented Jun 29, 2016

I've closed that issue; you should now be able to re-enable bundling.

@dhermes dhermes changed the title Consider re-enablnig GAX bundling for 'Topic.publish' Consider re-enabling GAX bundling for 'Topic.publish' Jun 29, 2016
@bjwatson bjwatson mentioned this issue Jun 30, 2016
Merged
@bjwatson
Copy link

bjwatson commented Jul 1, 2016

@tseaver You should be able to do this now that I published 0.7.11 of https://pypi.python.org/pypi/gax-google-pubsub-v1

@daspecster daspecster mentioned this issue Jul 1, 2016
Merged
@tseaver tseaver added the grpc label Jul 1, 2016
@tseaver
Copy link
Contributor Author

tseaver commented Jul 8, 2016

FTR, I think we don't want bundling, as we need to stay semantically-compatible with the JSON-over-HTTP version of the API helper.

@dhermes
Copy link
Contributor

dhermes commented Jul 18, 2016

@tseaver Is it worth adding a sibling method that allows bundling to take advantage of the nice HTTP/2 / gRPC features?

@tseaver
Copy link
Contributor Author

tseaver commented Jul 18, 2016

@dhermes I thought about that notion: also as a way to deal with the oft-desired (foot-gun?) of majyk-iterator-returning list_foo methods.

@bjwatson
Copy link

bjwatson commented Jul 18, 2016 •
edited
Loading

@dhermes @tseaver 👍

@tseaver
Copy link
Contributor Author

tseaver commented Jul 18, 2016

Maybe publish_async,returning the Event instance? It would have to raise NotImplementedError or some such if GAX is not enabled.

parthea pushed a commit that referenced this issue Jul 6, 2023
@andrewferlitsch @busunkim96
Fix decode [(#1911)](GoogleCloudPlatform/python-docs-samples#1911)
7c0fc56 
* fix decode problem

* fix decode

* fix decode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yoshi-automation yoshi-automation

Labels
api: pubsub Issues related to the Pub/Sub API. grpc type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@tseaver @bjwatson @dhermes @geigerj @yoshi-automation