Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_target_packages has dependencies in the wrong direction #3466

Closed
dhermes opened this issue Jun 2, 2017 · 0 comments
Closed

get_target_packages has dependencies in the wrong direction #3466

dhermes opened this issue Jun 2, 2017 · 0 comments
Assignees

Comments

@dhermes
Copy link
Contributor

dhermes commented Jun 2, 2017

We are adding dependencies during changes:

answer = answer.union(PKG_DEPENDENCIES.get(package, set()))

but this makes a build with logging only changes trigger BigQuery, Pub / Sub and Storage:

$ #!/bin/bash -eo pipefail
  python3.6 test_utils/scripts/get_target_packages.py > ~/target_packages
  cat ~/target_packages

bigquery
logging
pubsub
storage
  • logging depends on bigquery, pubsub, storage
  • error_reporting depends on logging

So the real output should be a reverse of the dependency map:

{'logging', 'error_reporting'}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants