-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Closed
Labels
🚨This issue needs some love.This issue needs some love.api: datastoreIssues related to the Datastore API.Issues related to the Datastore API.triage meI really want to be triaged.I really want to be triaged.
Description
The replacement will be handled by a string when dataset ID is explicitly needed (which will only be for power users). Some functionality will be moved to key.Key and the rest to the connection module as free functions. In order to make use easier, they will also have versions in __init__ which can use a default / implicit connection.
Steps to complete:
- Make
set_default_connectionsimilar toset_default_dataset(Address first part of 477: Implements datastore.set_default_connection. #478) - Remove
query(),entity(), andtransaction()methods fromDataset, replace their use elsewhere. (Address second part of 477: Remove query(), entity(), and transaction() methods from Dataset. #479) - Move
Dataset.get_entitytoKey(will impact elsewhere, e.g.Entity.reload) (Address third part of 477: Move Dataset.get_entity to Key. #480) - Move
save()anddelete()methodsdelete()method fromEntitytoKey(Address fourth part of 477: Moving Entity.delete to Key (for datastore). #481) - Move
allocate_ids()method fromDatasettoconnection__init__module as free function (Address fifth part of 477: Moves Dataset.allocate_ids to connection module. #482) - Move
get_entities()method fromDatasettoconnection__init__module as free function (Address sixth part of 477: Moves Dataset.get_entities to __init__ module. #483) - Fix
Remove dataset from Entity constructor and allow a key #484, Remove Query dependency on Dataset and make dataset_id required in Query #485, Remove Transaction dependency on Dataset #486- Lots to do to re-makeEntity,Query, andTransactionto not depend onDataset - Remove all remnants of
Dataset(e.g.set_default_dataset,Entity._must_dataset, and_implicit_environ._DatastoreBase) - Update stale documentation
NOTE: Don't close until cyclic-import in #480 is resolved.
See https://docs.google.com/document/d/1xKw8Tz6lfN5uOcv0my4uUgFSeDoRzwCLho2UGlBpqDU/edit for more.
Metadata
Metadata
Assignees
Labels
🚨This issue needs some love.This issue needs some love.api: datastoreIssues related to the Datastore API.Issues related to the Datastore API.triage meI really want to be triaged.I really want to be triaged.