Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default max_bytes in pubsub seems wrong #5898

Closed
ediphy-azorab opened this issue Sep 7, 2018 · 1 comment
Closed

Default max_bytes in pubsub seems wrong #5898

ediphy-azorab opened this issue Sep 7, 2018 · 1 comment
Assignees
@tseaver
Labels
api: pubsub Issues related to the Pub/Sub API. backend priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. type: question Request for information or clarification. Not an issue.

Comments

@ediphy-azorab
Copy link

https://github.com/GoogleCloudPlatform/google-cloud-python/blob/005ddd11770f8953643dac9b64a037524da2f49e/pubsub/google/cloud/pubsub_v1/types.py#L43

In my code I'm seeing this:

google.api_core.exceptions.InvalidArgument: 400 The value for 10159812 is too large. You passed request_size in the request, but the maximum value is 10000000.

Based on the error coming out of the pubsub, I think this default max size is wrong.
@tseaver tseaver added type: question Request for information or clarification. Not an issue. api: pubsub Issues related to the Pub/Sub API. backend labels Sep 7, 2018
@tseaver
Copy link
Contributor

tseaver commented Sep 7, 2018

The resource limits document specifies the per-message limit as "10MB." Until now, I'd never seen anybody but hard-disk manufacturers (trying to inflate the apparent size of their drives) interpret that as 10000000 bytes.

@tseaver tseaver added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Sep 7, 2018
@tseaver tseaver self-assigned this Sep 7, 2018
@tseaver tseaver mentioned this issue Sep 7, 2018
Merged
tseaver added a commit that referenced this issue Sep 7, 2018
@tseaver
Change 'BatchSettings.max_bytes' default. (#5899)
cbf90ec 
It is documented as '10MB', but enforced as 10000000 bytes.

Closes #5898.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tseaver tseaver

Labels
api: pubsub Issues related to the Pub/Sub API. backend priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. type: question Request for information or clarification. Not an issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tseaver @ediphy-azorab