-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify '_implicit_environ' handling #741
Comments
I like it. Was trying to move gradually towards this while building out the implicit functionality into The hardest thing to factor out is the dependence on the local concepts of |
Here's my notional take on a unification plan;
@dhermes WDYT? |
I don't see The rest seems great. RE: Project ID vs. App Engine App ID. We should ask someone with more knowledge of the current state of things. I think they are the same, but could be wrong. App Engine apps also have a default bucket created for them: |
#741: hoist GAE/GCD detection into `gcloud._helpers`
Re: |
#741: hoist project detection/setup into 'gcloud._helpers'.
#741: hoist `get_scoped_connection` into `connection`
@tseaver What's the status on this? |
I think that we are good, here: the default project stuff is shared, as is the repeated connection stuff (via |
There is a lot of overlap between
datastore._implicit_environ
andstorage._implicit_environ
. We should factor that out, especially before implementing yet another version inpubsub
.The text was updated successfully, but these errors were encountered: