Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(bigquery): add timeout parameter to client's and job's public methods #10002

Merged
merged 7 commits into from
Dec 26, 2019
Merged

feat(bigquery): add timeout parameter to client's and job's public methods #10002

merged 7 commits into from
Dec 26, 2019

Commits on Dec 19, 2019

  1. Reverse argument order in job.result() 

    This is for internal consistency with other methods such as reload().
    @plamut
    plamut committed Dec 19, 2019
    Configuration menu
    Copy the full SHA
    10bdfe8 View commit details
    Browse the repository at this point in the history

  2. Add TODO reminder to _AsyncJob.cancel() method

    @plamut
    plamut committed Dec 19, 2019
    Configuration menu
    Copy the full SHA
    c50b897 View commit details
    Browse the repository at this point in the history

  3. Add timeout argument to public methods 

    AN exception is the Client.load_table_from_file() method, and the
methods that depend on it, because adding a timeout requires changes
in the google-resumable-media dependency.
    @plamut
    plamut committed Dec 19, 2019
    Configuration menu
    Copy the full SHA
    b782374 View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2019

  1. Explicitly test timeout parameter

    @plamut
    plamut committed Dec 20, 2019
    Configuration menu
    Copy the full SHA
    a5188cb View commit details
    Browse the repository at this point in the history

Commits on Dec 23, 2019

  1. Split timeout in multi-request methods 

    If a method makes multiple requests and is given a timeout, that
timeout should represent the total allowed time for all requests
combined.
    @plamut
    plamut committed Dec 23, 2019
    Configuration menu
    Copy the full SHA
    769c80b View commit details
    Browse the repository at this point in the history

  2. Fix minor styling issue

    @plamut
    plamut committed Dec 23, 2019
    Configuration menu
    Copy the full SHA
    4cfd474 View commit details
    Browse the repository at this point in the history

Commits on Dec 26, 2019

  1. Add timeout with retry test for Client._call_api()

    @plamut
    plamut committed Dec 26, 2019
    Configuration menu
    Copy the full SHA
    b01d214 View commit details
    Browse the repository at this point in the history