Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(spanner): fix instance docstrings #10106

Merged
merged 1 commit into from
Jan 14, 2020

Conversation

IlyaFaer
Copy link

Fixes #10099

@IlyaFaer IlyaFaer added api: spanner Issues related to the Spanner API. type: docs Improvement to the documentation for an API. labels Jan 13, 2020
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 13, 2020
instance.display_name = 'New display name'
instance.node_count = 5
instance.display_name = 'New display name'
instance.node_count = 5
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because of wrong whitespaces line before calling :meth:`update`. was treated as Python code

@IlyaFaer
Copy link
Author

IlyaFaer commented Jan 13, 2020

Docs with new changes looks okay:
Безымянный

@IlyaFaer IlyaFaer requested review from plamut and larkee January 13, 2020 11:12
@IlyaFaer IlyaFaer marked this pull request as ready for review January 13, 2020 11:12
Copy link
Contributor

@larkee larkee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the Spanner API. cla: yes This human has signed the Contributor License Agreement. type: docs Improvement to the documentation for an API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spanner: Building the docs fails
3 participants