Add tabledata API methods #1038

tseaver · 2015-08-05T21:18:33Z

Add Table.insert_all() and Table.data for synchronous load / browse.
Ensure that Table.schema is re-populated from server responses.

gcloud/bigquery/table.py

- 'data' -> 'fetch_data' - 'insert_all' -> 'insert_data' Addresses: #1038 (comment)

See: #1038 (comment)

gcloud/bigquery/table.py

dhermes · 2015-08-06T16:10:52Z

RE:

(I found this in the wild when trying to fetch data I had sent as "normal" numeric values).

JavaScript has no 64 bits integers but only one number type, which is the IEEE754 double precision float.

So the JSON spec can't support int64 values. See the discovery spec to see how values actually get encoded.

Addresses: #1038 (comment)

Addresses: #1038 (comment) #1038 (comment) #1038 (comment)

Even though it doesn't return values in native JSON types when fetched, the back-end is willing to accept them during insert. Addresses: #1038 (comment)

Addresses: #1038 (comment)

dhermes · 2015-08-06T23:21:29Z

LGTM

Add tabledata API methods

dhermes · 2015-08-07T00:01:02Z

@tseaver Where do we stand on cutting a release?

tseaver · 2015-08-07T14:39:43Z

We don't have any of the job-related APIs covered for BQ. I don't know whether that should be a blocker: @jgeewax, do you have a sense?

dhermes · 2015-08-07T15:18:31Z

If it's just a 0.7.1 it's not a big deal. Getting into a rhythm of releasing every week could be good anyhow?

tseaver · 2015-08-07T18:09:48Z

Maybe so. If it is a 0.7.1, we should either ignore BQ altogether, or note that it is under heavy development and not really ready for outside use yet.

dhermes · 2015-08-07T18:10:36Z

OK

[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [protobuf](https://developers.google.com/protocol-buffers/) | `==3.18.1` -> `==3.19.0` | [![age](https://badges.renovateapi.com/packages/pypi/protobuf/3.19.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/protobuf/3.19.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/protobuf/3.19.0/compatibility-slim/3.18.1)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/protobuf/3.19.0/confidence-slim/3.18.1)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/gapic-generator-python).

* chore(python): remove CONTRIBUTING.rst from templates Source-Link: googleapis/synthtool@c96fb11 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:710b70faff81151657d89db6e028c23a1051787598c8276bdd8eef25c92da8ab * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Remove replacement in owlbot.py --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>

tseaver added 3 commits August 5, 2015 16:25

Add 'Table.insert_all()' and 'Table.data' for synchronous load / browse.

52859a8

Ensure that 'Table.schema' is re-populated from server responses.

96f448c

Fix spec url for 'Table.insert_all'.

875b29b

tseaver added the api: bigquery Issues related to the BigQuery API. label Aug 5, 2015

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 5, 2015

dhermes reviewed Aug 6, 2015
View reviewed changes

gcloud/bigquery/table.py

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

tseaver added 3 commits August 6, 2015 10:01

Rename tabledata methods for clarity.

d9ca381

- 'data' -> 'fetch_data' - 'insert_all' -> 'insert_data' Addresses: #1038 (comment)

Add support for fetch / insert data w/ RECORD fields.

4a421f0

See: #1038 (comment)

Add support for fetch / insert data w/ mode=NULLABLE fields.

8ce372f

dhermes reviewed Aug 6, 2015
View reviewed changes

gcloud/bigquery/table.py

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Avoid 'if converter is None:'.

7355823

Addresses: #1038 (comment)

tseaver added 5 commits August 6, 2015 13:26

Normalize quote usage in testcase datastructures.

3a8afd1

Addresses: #1038 (comment)

Moar quote normalization.

bba54da

Addresses: #1038 (comment) #1038 (comment) #1038 (comment)

Add support, tests for fields w/ 'mode=REPEATED'.

865df91

Drop field_type-based dispatch for 'Table.insert_all'.

8dcc351

Even though it doesn't return values in native JSON types when fetched, the back-end is willing to accept them during insert. Addresses: #1038 (comment)

Add notice in 'fetch_data' docstring about out-of-date schema issues.

12d9ee1

Addresses: #1038 (comment)

tseaver added a commit that referenced this pull request Aug 6, 2015

Merge pull request #1038 from tseaver/bigquery-tabledata_api_methods

3d0e871

Add tabledata API methods

tseaver merged commit 3d0e871 into googleapis:master Aug 6, 2015

tseaver deleted the bigquery-tabledata_api_methods branch August 6, 2015 23:56

dhermes mentioned this pull request Aug 12, 2015

Upgrading version to 0.7.1. #1057

Merged

parthea pushed a commit that referenced this pull request Nov 24, 2025

chore(deps): update dependency pyparsing to v3.1.2 (#1038)

49c070c

parthea pushed a commit that referenced this pull request Nov 26, 2025

chore: update sys test creds (#1038)

6646855

Add tabledata API methods #1038

Add tabledata API methods #1038

Uh oh!

Conversation

tseaver commented Aug 5, 2015

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

dhermes commented Aug 6, 2015

Uh oh!

dhermes commented Aug 6, 2015

Uh oh!

dhermes commented Aug 7, 2015

Uh oh!

tseaver commented Aug 7, 2015

Uh oh!

dhermes commented Aug 7, 2015

Uh oh!

tseaver commented Aug 7, 2015

Uh oh!

dhermes commented Aug 7, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants