Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding BigQuery and Pub/Sub to README. #1078

Merged
merged 1 commit into from
Aug 24, 2015
Merged

Adding BigQuery and Pub/Sub to README. #1078

merged 1 commit into from
Aug 24, 2015

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Aug 24, 2015

@dhermes dhermes added the docs label Aug 24, 2015
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 24, 2015
@dhermes
Copy link
Contributor Author

dhermes commented Aug 24, 2015

Notice I also changed the relative #google-cloud-storage links to absolute ones. This is because they don't get rendered on https://pypi.python.org/pypi/gcloud when they are relative (and having relative "CONTRIBUTING" actually complete broke the PyPI RST parser before).

Maybe we should add something to our CONTRIBUTING doc warning about using non-absolute links in the README?

@tseaver
Copy link
Contributor

tseaver commented Aug 24, 2015

LGTM.

A note in CONTRIBUTING.rst might help, if only there were impetus to read it. :)

dhermes added a commit that referenced this pull request Aug 24, 2015
@dhermes
Merge pull request #1078 from dhermes/fix-1076
34d652e 
Adding BigQuery and Pub/Sub to README.
@dhermes dhermes merged commit 34d652e into googleapis:master Aug 24, 2015
@dhermes dhermes deleted the fix-1076 branch August 24, 2015 20:13
@dhermes
Copy link
Contributor Author

dhermes commented Aug 24, 2015

You don't think the doc is worthwhile?

@tseaver
Copy link
Contributor

tseaver commented Aug 24, 2015

I just meant that you and I are the ones most likely to forget, and least likely of all to look at CONTRIBUTING.rst. Go ahead and add the note.

@dhermes
Copy link
Contributor Author

dhermes commented Aug 24, 2015

Ah gotcher.

@dhermes dhermes mentioned this pull request Sep 30, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

README.rst page doesn't mention the pub/sub client or bq
3 participants
@dhermes @tseaver @googlebot