-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Adding link to gcloud-java from landing page #1095
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
LGTM. Can you also submit one against https://github.com/GoogleCloudPlatform/gcloud-python/blob/b3ee1491d0e55a41087c53f5f1d41e0bd7785a3c/docs/_templates/layout.html in |
Adding link to gcloud-java from landing page
|
Sure, I can do that |
|
Thanks. It's my / our bad for not having one true place for that HTML. |
|
Oh, before I make that change, gcloud-java doesn't use the same template for the docs pages. Instead we use the javadoc template (see http://googlecloudplatform.github.io/gcloud-java/site/0.0.7/apidocs/index.html). Would it be alright if the link in docs/_templates/layout.html linked that? |
|
Use whichever link you think is appropriate. @jgeewax Can sign off if you think it needs a second set of eyes. |
|
For now, I'd rather link to the landing page if that's OK... Quite a few people wanted to see "what each language offers", and if we send people into the Javadocs, they lose their language switcher drop-down. Is that cool? |
* fix: refactor credential subclass parameters * Changes requested by @clundin25 * hotlinking __init__ method * punctuation * getting unit tests to pass * fixing comments * Refresh system test token. Co-authored-by: Leo <39062083+lsirac@users.noreply.github.com> Co-authored-by: Carl Lundin <clundin@google.com>
This pull request adds a link to gcloud-java in the landing page dropdown menu in the upper left hand corner.