Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround tox 2.3.0 regression. #1285

Merged
merged 1 commit into from
Dec 11, 2015
Merged

Workaround tox 2.3.0 regression. #1285

merged 1 commit into from
Dec 11, 2015

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Dec 11, 2015

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 11, 2015
@tseaver
Copy link
Contributor Author

tseaver commented Dec 11, 2015

@dhermes @jgeewax This one is pretty urgent: all our tests break with tox 2.3.0. I intend to merge as soon as Travis is green.

@dhermes
Copy link
Contributor

dhermes commented Dec 11, 2015

I have a better fix.

@dhermes
Copy link
Contributor

dhermes commented Dec 11, 2015

ISTM the issue is the use of {[testenv]setenv}. This is very similar to the issue you linked to.

@dhermes
Copy link
Contributor

dhermes commented Dec 11, 2015

diff --git a/tox.ini b/tox.ini
index e92ace7..0b3b727 100644
--- a/tox.ini
+++ b/tox.ini
@@ -54,7 +54,7 @@ passenv = {[testenv:system-tests]passenv} SPHINX_RELEASE READTHEDOCS LOCAL_RTD

 [testenv:docs-rtd]
 setenv =
-    {[testenv]setenv}
+    PYTHONPATH = {toxinidir}/_testing
     LOCAL_RTD = True
 basepython = {[testenv:docs]basepython}
 commands =

@dhermes
Copy link
Contributor

dhermes commented Dec 11, 2015

Just ran tox -e py27 with this change and it passed with no issues.

@dhermes
Copy link
Contributor

dhermes commented Dec 11, 2015

Ditto on py26,py33,py34,cover and lint.

@tseaver
Copy link
Contributor Author

tseaver commented Dec 11, 2015

@dhermes I'm not sure what you mean: do you want to push a different PR? Or do you think I should update this one?

@dhermes
Copy link
Contributor

dhermes commented Dec 11, 2015

Just update this one and feel free to merge if you can get Travis to pass

tseaver added a commit that referenced this pull request Dec 11, 2015
@tseaver tseaver merged commit 6fe480d into googleapis:master Dec 11, 2015
@tseaver tseaver deleted the workaround-tox-2.3-regression branch December 11, 2015 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants