Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing datastore Batch.add_auto_id_entity. #1296

Merged
merged 1 commit into from
Dec 17, 2015

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Dec 17, 2015

This mutation type has been removed in v1beta3 so we
just use Batch.put() to handle the previous duty.

Also simplifying the helper which populates a protobuf entity
from a gcloud-python Entity.

@dhermes dhermes added the api: datastore Issues related to the Datastore API. label Dec 17, 2015
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 17, 2015
@dhermes dhermes mentioned this pull request Dec 17, 2015
49 tasks
@tseaver
Copy link
Contributor

tseaver commented Dec 17, 2015

LGTM, modulo conflicts.

This mutation type has been removed in v1beta3 so we
just use Batch.put() to handle the previous duty.

Also simplifying the helper which populates a protobuf entity
from a gcloud-python Entity.
@dhermes dhermes force-pushed the remove-datastore-add-auto-id branch from 0ff93cb to 3ec13ca Compare December 17, 2015 16:59
dhermes added a commit that referenced this pull request Dec 17, 2015
Removing datastore Batch.add_auto_id_entity.
@dhermes dhermes merged commit 8b09538 into googleapis:master Dec 17, 2015
@dhermes dhermes deleted the remove-datastore-add-auto-id branch December 17, 2015 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: datastore Issues related to the Datastore API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants