Moving _pb_timestamp_to_datetime into core. #1361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhermes
added
api: datastore
googlebot
added
the
cla: yes
|
Rather than copying the generated files into our own package here, it might be good to generate all the proto-based files for BigTable in a separate package, and just import them like the ones from |
|
I agree and it's something that's been discussed with @tbetbetbe but I don't think it's worth blocking this PR. WDYT? |
|
I'm actually thinking it would be better than what I proposed in #1317: if we could work out generating releasing the Python code from the protos as a separate project, we would simplify our own bits here, and maybe get to piggyback stuff like the Makefile in googleapis (note that it doesn't seem to support Python, so I'm not sure how they are generating |
dhermes
force-pushed
the
move-_pb_timestamp_to_datetime
branch
2 times, most recently
from
be6e3bb to
e0f0c60
Compare
This is in advance of `v1beta3`, where it will be needed to parse `Value.timestamp_value` (which is of type `timestamp_pb2.Timestamp`). Also adding `_datetime_to_pb_timestamp` for the other direction.
dhermes
force-pushed
the
move-_pb_timestamp_to_datetime
branch
from
e0f0c60 to
d3058f3
Compare
|
LGTM |
dhermes
added a commit
that referenced
this pull request
Jan 15, 2016
Moving _pb_timestamp_to_datetime into core.
atulep
pushed a commit
that referenced
this pull request
Apr 6, 2023
…les#1361) * add transcribe_model_selection * add transcribe_model_selection_test * flake
atulep
pushed a commit
that referenced
this pull request
Apr 6, 2023
…les#1361) * add transcribe_model_selection * add transcribe_model_selection_test * flake
atulep
pushed a commit
that referenced
this pull request
Apr 18, 2023
…les#1361) * add transcribe_model_selection * add transcribe_model_selection_test * flake
parthea
pushed a commit
that referenced
this pull request
Oct 22, 2023
…les#1361) * add transcribe_model_selection * add transcribe_model_selection_test * flake
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in advance of
v1beta3, where it will be needed to parseValue.timestamp_value(which is of typetimestamp_pb2.Timestamp). Also adding_datetime_to_pb_timestampfor the other direction.NOTE: Has #1353 as diffbase.