Skip to content

Conversation

@tseaver
Copy link
Contributor

@tseaver tseaver commented Feb 17, 2016

e2b3ef7 also cleans up the order of testcase methods to match the actual order of Message methods.

Closes #1480

@tseaver tseaver added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. api: pubsub Issues related to the Pub/Sub API. labels Feb 17, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 17, 2016
@dhermes
Copy link
Contributor

dhermes commented Feb 17, 2016

@tseaver Can you rebase since #1479 is in now?

@dhermes
Copy link
Contributor

dhermes commented Feb 17, 2016

LGTM pending rebase / Travis

tseaver added a commit that referenced this pull request Feb 17, 2016
…ng_data

Harden 'Message.from_api_repr' against missing 'data'
@tseaver tseaver merged commit 87c7a4c into googleapis:master Feb 17, 2016
@tseaver tseaver deleted the 1480-pubsub-empty_payload-missing_data branch February 17, 2016 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants