Skip to content

Conversation

@tseaver
Copy link
Contributor

@tseaver tseaver commented Mar 2, 2016

Cleaner alternative to PR #1556, with coverage.

@tseaver tseaver added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. api: storage Issues related to the Cloud Storage API. labels Mar 2, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 2, 2016
"""
client = self._require_client(client)
if self.media_link is None: # not yet loaded
self.reload()

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

@dhermes
Copy link
Contributor

dhermes commented Mar 3, 2016

LGTM pending Travis

tseaver added a commit that referenced this pull request Mar 3, 2016
#1555: reload missing properties before blob download
@tseaver tseaver merged commit cba090e into googleapis:master Mar 3, 2016
@tseaver tseaver deleted the 1555-reload_on_missing_media_link branch March 3, 2016 16:29
parthea pushed a commit that referenced this pull request Nov 26, 2025
* feat: implement async oauth2 credentials

* minor cleanup

* inherit base credentials class in async credentials

* fix whitespace

* implement builder class for oauth 2.0 credentials

* feat: implement async static credentials

* revert implementing oauth2 credentials

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* update values used in tests

* update the exception raised for static refresh

* add async anonymous credentials

* update docstrings

* address PR comments

* chore: Refresh system test creds.

* fix lint issues

* add test coverage

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Carl Lundin <clundin@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants