Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'Metrics.update' API wrapper. #1587

Merged
merged 2 commits into from
Mar 14, 2016
Merged

Add 'Metrics.update' API wrapper. #1587

merged 2 commits into from
Mar 14, 2016

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Mar 8, 2016

Uses #1586 as a base.

@tseaver tseaver added the api: logging Issues related to the Cloud Logging API. label Mar 8, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 8, 2016
@tseaver
Copy link
Contributor Author

tseaver commented Mar 13, 2016

@dhermes Rebased after merging #1586 to logging-api branch. PTAL

@@ -186,8 +186,6 @@ Update a metric:
>>> from gcloud import logging
>>> client = logging.Client()
>>> metric = client.metric("robots")
>>> metric.exists() # API call
True

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

@dhermes
Copy link
Contributor

dhermes commented Mar 13, 2016

LGTM, though I think the .rst file was fine before?

tseaver added a commit that referenced this pull request Mar 14, 2016
@tseaver tseaver merged commit 0283a36 into googleapis:logging-api Mar 14, 2016
@tseaver tseaver deleted the logging-metric_update branch March 14, 2016 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: logging Issues related to the Cloud Logging API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants