Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add system test for 'logger.log_text' and 'logger.log_struct'. #1609

Merged
merged 1 commit into from
Mar 17, 2016
Merged

Add system test for 'logger.log_text' and 'logger.log_struct'. #1609

merged 1 commit into from
Mar 17, 2016

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Mar 15, 2016

No description provided.

@tseaver tseaver added the api: logging Issues related to the Cloud Logging API. label Mar 15, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 15, 2016
@tseaver tseaver mentioned this pull request Mar 15, 2016
Merged
dhermes
dhermes reviewed Mar 15, 2016
View reviewed changes
system_tests/logging_.py


def setUpModule():
_helpers.PROJECT = TESTS_PROJECT

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@tseaver tseaver mentioned this pull request Mar 15, 2016
Closed
@tseaver tseaver changed the title System test for 'logger.log_text' and 'logger.log_struct'. Add system test for 'logger.log_text' and 'logger.log_struct'. Mar 15, 2016
@tseaver tseaver mentioned this pull request Mar 16, 2016
Closed
@tseaver
Copy link
Contributor Author

tseaver commented Mar 17, 2016

@dhermes any remaining issues?

@tseaver
Copy link
Contributor Author

tseaver commented Mar 17, 2016

Rebased after merging #1616 to the logging-api branch.

@dhermes
Copy link
Contributor

dhermes commented Mar 17, 2016

LGTM. The eventual consistency hack might be easier to find if you factor it out into a helper (like is done in the bigtable test).

@tseaver
Copy link
Contributor Author

tseaver commented Mar 17, 2016

The eventual consistency hack might be easier to find if you factor it out into a helper (like is done in the bigtable test).

I've been thinking about a more generic retry wrapper (per #1619).

tseaver added a commit that referenced this pull request Mar 17, 2016
@tseaver
Merge pull request #1609 from tseaver/logging-system_test-logger_log
57fed8a 
Add system test for 'logger.log_text' and 'logger.log_struct'.
@tseaver tseaver merged commit 57fed8a into googleapis:logging-api Mar 17, 2016
@tseaver tseaver deleted the logging-system_test-logger_log branch March 17, 2016 13:45
@dhermes
Copy link
Contributor

dhermes commented Mar 18, 2016

@tseaver I made a generic retry wrapper in #535

@dhermes dhermes mentioned this pull request Apr 1, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: logging Issues related to the Cloud Logging API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tseaver @dhermes @googlebot