Add system test for 'Client.list_metrics'. #1611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
This was referenced Mar 15, 2016
Adjust 'Metric.from_api_repr' and associated tests to accomodate the fact that the 'LogMetric' resource does not contain a fully-qualified path, but only the simple name.
| """ | ||
| metric_name = _metric_name_from_path(resource['name'], client.project) | ||
| metric_name = resource['name'] |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Side question: Can we turn these on to run in Travis? |
| DEFAULT_METRIC_NAME, DEFAULT_FILTER, DEFAULT_DESCRIPTION) | ||
| self.assertFalse(metric.exists()) | ||
| before_metrics, _ = Config.CLIENT.list_metrics() | ||
| before_names = set(metric.name for metric in before_metrics) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
The |
|
LGTM |
tseaver
added a commit
that referenced
this pull request
Mar 18, 2016
…_metrics Add system test for 'Client.list_metrics'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses #1610 as a base.Note the changes to
gcloud.logging: the system test revealed that the API returns "simple" names for theLogMetricresource (as documented, but which I misread as returning fully-qualified paths).