Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1577: allow logging protobuf entries #1661

Merged
merged 4 commits into from
Mar 26, 2016
Merged

#1577: allow logging protobuf entries #1661

merged 4 commits into from
Mar 26, 2016

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Mar 25, 2016

Also, add a helper to parse an entry's payload into a protobuf message object.

Closes #1577

@tseaver tseaver added the api: logging Issues related to the Cloud Logging API. label Mar 25, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 25, 2016
@tseaver
Copy link
Contributor Author

tseaver commented Mar 25, 2016

Python 3.4 test failure is due to protocolbuffers/protobuf#1352.

I will work around by using a different message type.

@tseaver
Copy link
Contributor Author

tseaver commented Mar 25, 2016

@dhermes, @jgeewax PTAL

dhermes
dhermes reviewed Mar 25, 2016
View reviewed changes
gcloud/logging/entries.py
:type message: Protobuf message
:param message: the message to be logged
"""
Parse(json.dumps(self.payload), message)

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@dhermes
Copy link
Contributor

dhermes commented Mar 25, 2016

LGTM pending docstring update

@tseaver tseaver merged commit cd18373 into googleapis:logging-api Mar 26, 2016
@tseaver tseaver deleted the 1577-logging-protobuf_load_dump branch March 26, 2016 04:40
@tseaver tseaver mentioned this pull request Mar 29, 2016
Closed
@dhermes dhermes mentioned this pull request Apr 1, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: logging Issues related to the Cloud Logging API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tseaver @dhermes @googlebot