Small pylint clean-up. #1780
Merged
Small pylint clean-up. #1780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
I'd be in favor of globally disabling |
|
Good point. 100% code coverage makes all true import failures abundantly clear. |
|
@tseaver PTAL |
| @@ -87,6 +87,10 @@ load-plugins=pylint.extensions.check_docs | |||
| # """Hi everyone""" | |||
| # and thus causes subsequent imports to be | |||
| # diagnosed as out-of-order. | |||
| # - wrong-import-position: This error is overzealous. It assumes imports are | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
OK @tseaver I got rid of the erroneous line. Is this good to merge (after squashing)? |
|
LGTM |
- Increasing test lines limit to 1900 and removing a line limit ignore at the top of the file - Disabling no-name-in-module since requiring 100% code coverage guarantees we exercise all imports - Making remaining disables use verbose names instead of short names - Locally re-enabling too-many-statements in gcloud/bigquery/test_table.py (was disabled at a scope but never re-enabled)
dhermes
force-pushed
the
tiny-pylint-cleanup
branch
from
bfd32e7 to
0352542
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gcloud/bigquery/test_table.py(was disabled at a scope but never re-enabled)@tseaver This was inspired by #1779 (e.g. my comment made me wonder about this)