Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommend new ADC command #1851

Merged
merged 1 commit into from
Jun 10, 2016
Merged

Recommend new ADC command #1851

merged 1 commit into from
Jun 10, 2016

Conversation

waprin
Copy link
Contributor

@waprin waprin commented Jun 10, 2016

gcloud has a new command for creating ADC. The idea is that gcloud auth login is for authenticating the CLI and gcloud beta auth application-default login creates credentials for client code. After a transition period, gcloud auth login will no longer write credentials to a well-known file and so will not work.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 10, 2016
@tseaver
Copy link
Contributor

tseaver commented Jun 10, 2016

@waprin How new is the ADC command? Are our users likely to be using older gcloud CLI without it?

@waprin
Copy link
Contributor Author

waprin commented Jun 10, 2016

It came out in late March. I would say most users should be updating their gcloud frequently enough that they should have it. Our official auth docs recommend it instead of gcloud auth login.

It is still in beta and it's a confusing change so I don't blame you if you want to hold off. However I asked the PM responsible for auth on the platform and he told me I should recommend the change (with apologies for the confusion). And again, sooner or later this change will be necessary since gcloud auth login will stop writing the credentials.

@tseaver
Copy link
Contributor

tseaver commented Jun 10, 2016

Maybe the last graph should add a sentence pointing to the docs for updating the gcloud CLI? Something like:

Previously, gcloud auth login was used for both use cases. If your gcloud installation does not support the new commend, please update it: see {URL HERE}.

@tseaver tseaver self-assigned this Jun 10, 2016
@waprin
Copy link
Contributor Author

waprin commented Jun 10, 2016

The CLI can update itself so I just added the command to do that.

@tseaver tseaver merged commit c252631 into googleapis:master Jun 10, 2016
@tseaver
Copy link
Contributor

tseaver commented Jun 10, 2016

@waprin Thanks for the patch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auth cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants