Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Py3k compatibility for snippet execution. #1860

Merged
merged 1 commit into from
Jun 16, 2016
Merged

Py3k compatibility for snippet execution. #1860

merged 1 commit into from
Jun 16, 2016

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Jun 15, 2016

Exercising grpcio and related packages under Python 3.4, per grpc/grpc#282 (comment)

@tseaver tseaver added docs testing api: pubsub Issues related to the Pub/Sub API. labels Jun 15, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 15, 2016
@tseaver
Copy link
Contributor Author

tseaver commented Jun 15, 2016

@daspecster PTAL

@daspecster
Copy link
Contributor

@tseaver How do you run these? Or when are they run?

@tseaver
Copy link
Contributor Author

tseaver commented Jun 15, 2016

How do you run these? Or when are they run?

@daspecster I've been running them like system tests, in an environment with project / auth set up. I use the following command:

$ .tox/system-tests/bin/python docs/pubsub_snippets.py

@daspecster
Copy link
Contributor

@tseaver LGTM! Should we put this in the #1854 release?

@tseaver
Copy link
Contributor Author

tseaver commented Jun 16, 2016

It isn't really user-visible, yet, so we can go either way.

@daspecster daspecster merged commit 5fc0c01 into googleapis:master Jun 16, 2016
@daspecster daspecster mentioned this pull request Jun 16, 2016
7 tasks
@tseaver tseaver deleted the pubsub-enable_snippets_under_py3k branch June 16, 2016 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement. testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants