Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull in 'gax-google-logging-v2' dependency. #1880

Merged
merged 1 commit into from
Jun 21, 2016
Merged

Pull in 'gax-google-logging-v2' dependency. #1880

merged 1 commit into from
Jun 21, 2016

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Jun 20, 2016

No description provided.

@tseaver tseaver added the api: logging Issues related to the Cloud Logging API. label Jun 20, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 20, 2016
@daspecster
Copy link
Contributor

With the grpcio issues, do you know if this works in py2/py3?

@tseaver
Copy link
Contributor Author

tseaver commented Jun 21, 2016

@daspecster The core issue from #1879 is the same either way.

@daspecster
Copy link
Contributor

LGTM

@tseaver tseaver merged commit 22bf022 into googleapis:master Jun 21, 2016
@tseaver tseaver deleted the logging-gax_dependencies branch June 21, 2016 00:19
@tseaver tseaver mentioned this pull request Jun 29, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: logging Issues related to the Cloud Logging API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tseaver @daspecster @googlebot