Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Python 2.6 on appveyor, install 'grpcio' unconditionally. #1882

Merged
merged 1 commit into from
Jun 21, 2016
Merged

Drop Python 2.6 on appveyor, install 'grpcio' unconditionally. #1882

merged 1 commit into from
Jun 21, 2016

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Jun 21, 2016

grpcio 0.14.0 installs without errors on Python 3.4+.

See #1863, failures after merging #1877.

@tseaver tseaver added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. testing labels Jun 21, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 21, 2016
@daspecster
Copy link
Contributor

daspecster commented Jun 21, 2016

@tseaver, do you have appveyor hooked up to your github username? or if you want I can copy this branch to my repo and run it.

Update: Build running @ https://ci.appveyor.com/project/daspecster/gcloud-python-pjqjn

@tseaver tseaver merged commit 45a3b51 into googleapis:master Jun 21, 2016
@tseaver
Copy link
Contributor Author

tseaver commented Jun 21, 2016

Oops, I was out-of-sync and merged ahead of seeing your build finish.

@daspecster
Copy link
Contributor

Np, I have it building master now https://ci.appveyor.com/project/daspecster/gcloud-python-pjqjn

@daspecster
Copy link
Contributor

@daspecster
Copy link
Contributor

@tseaver
Copy link
Contributor Author

tseaver commented Jun 21, 2016

Ugh. I'm not sure what to say: somebody has hosed the google namespace package.

@daspecster
Copy link
Contributor

For windows specifically?

@daspecster
Copy link
Contributor

@daspecster
Copy link
Contributor

Could try and switching protobuf == 3.0.0b2 from 3.0.0b3?

@tseaver
Copy link
Contributor Author

tseaver commented Jun 21, 2016

Maybe we should revert this PR (or at least the bit which globally installs grpcio) and just leave Appveyor borken until a fix is released for grpc/grpc#6939.

@daspecster
Copy link
Contributor

Wouldn't we want it this way once grpc/grpc#6939 is resolved?

@tseaver tseaver deleted the 1877-moar-appveyour-grpc-fixing branch June 27, 2016 15:04
@tseaver tseaver mentioned this pull request Jun 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. testing type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants