-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #141: remove spurious *args / **kwargs from API methods. #195
Closed
tseaver
wants to merge
32
commits into
googleapis:master
from
tseaver:141-connection.get_bucket-spurious_args_kwargs
Closed
Changes from 1 commit
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
a7e8864
Fix #133: preserve PB namespace in Key.from_protobuf.
tseaver a077d7d
Add docstrings for API method of g.datastore.key.Key.
tseaver 0e625da
Fix #134: enforce contract that *args must be pairs.
tseaver fe1450b
Propose a contract for Key.parent.
tseaver c8f6aa4
Fix #135: enforce contract for Key.parent().
tseaver f107fda
Incorporate feedback from @dhermes.
tseaver 7076c4d
Merge branch 'add_key_docstrings' into 133-key.from_protobuf-preserve…
tseaver 19c6382
Merge branch 'add_key_docstrings' into 134-key-from_path-contract
tseaver 4500f5e
Merge branch 'add_key_docstrings' into 135-key-parent-contract
tseaver 37dd328
Incorporate feedback from @dhermes.
tseaver d1280f3
Incorporate feedback from @dhermes.
tseaver 8ce18c9
Merge branch 'add_key_docstrings' into 135-key-parent-contract
tseaver e6ad297
Fix #137: default key based on filename.
tseaver fb756b2
Fix #138: clear existing (local) ACL when saving ACL to server.
tseaver 2f93065
Added bucket method to upload files from a file object.
e19cf86
Fix #139: clear existing (local) ACL when saving defaultObjectACL to…
tseaver ccd8a5e
Fix #140: make 'path' required for Connection.api_request.
tseaver e346282
Fix #141: remove spurious *args / **kwargs from API methods.
tseaver be6e9b7
Fix #143: off-by-one range in iterator.KeyIterator.get_headers.
tseaver 0a5fe6b
Merge pull request #184 from tseaver/add_key_docstrings
silvolu 5c3d8ae
Merge pull request #198 from dhermes/datastore-cnxn-inherit-generic
silvolu 62e887d
Merge pull request #145 from kleyow/files
silvolu 60887ab
Merge pull request #191 from tseaver/137-upload_file-guess_key_based_…
silvolu 23fc80f
Merge pull request #192 from tseaver/138-save_acl-clear_existing_loca…
silvolu d8b4e36
Merge pull request #193 from tseaver/139-save_default_object_acl-clea…
silvolu 3bd6bd8
Merge pull request #194 from tseaver/140-connection.api_request-handl…
silvolu bc53038
Merge pull request #196 from tseaver/143-storage.iterator.KeyDataIter…
silvolu 77e5f0b
Merge pull request #183 from tseaver/133-key.from_protobuf-preserve-n…
silvolu 1bb281c
Merge pull request #185 from tseaver/134-key-from_path-contract
silvolu 9af7d1b
Merge pull request #186 from tseaver/135-key-parent-contract
silvolu b848468
Fix #141: remove spurious *args / **kwargs from API methods.
tseaver 0ba7398
Merge branch '141-connection.get_bucket-spurious_args_kwargs' of gith…
tseaver File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
Sorry, something went wrong.