Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable pylint 1.6 warnings / work around breakage #1974

Merged
merged 5 commits into from
Jul 12, 2016
Merged

Disable pylint 1.6 warnings / work around breakage #1974

merged 5 commits into from
Jul 12, 2016

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Jul 11, 2016

Work around pylint-dev/pylint#998

Globally disable new warnings (rather than just for tests, as in #1967).

Run pylint a single file at a time: if any exits with a non-zero status, record the name and status and continue (this helped debug the issue above).

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 11, 2016
@tseaver tseaver merged commit a1620a9 into googleapis:master Jul 12, 2016
@tseaver tseaver deleted the pylint-disable-pylint-1.6-warnings-breakage branch July 12, 2016 12:11
@daspecster
Copy link
Contributor

Should we set the pylint version back to 1.5.6?

@tseaver
Copy link
Contributor Author

tseaver commented Jul 12, 2016

AFAIK this PR should make pylint 1.6 work fine for us.

@daspecster
Copy link
Contributor

Yeah it did, and I see that pylint-dev/pylint#998 is getting jumped on pretty quick. Never mind then :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants