Add missing exception class for '502 Bad Gateway' response code. #2078
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We do see such (transient) errors in the wild.
googlebot
added
the
cla: yes
|
|
||
| class BadGateway(ServerError): | ||
| """Exception mapping a '502 Bad Gateway' response.""" | ||
| code = 502 |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
|
LGTM (aside from my question, we can address outside of this) |
Contributor
|
@tseaver Why not use |
Contributor
Author
|
Those constants don't seem to me to add any value here: the actual code is what matters, and we are mapping to our own class hierarchy. |
Contributor
|
It's just more canonical than a bunch of constant int values scatterred around |
Contributor
Author
|
They are hardly "scattered": each one is in the class which defines its meaning. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do see such (transient) errors in the wild.