Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable GAX by default if it is importable. #2085

Merged
merged 2 commits into from
Aug 10, 2016
Merged

Re-enable GAX by default if it is importable. #2085

merged 2 commits into from
Aug 10, 2016

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Aug 10, 2016

As of the 0.8.1 versions of the wrappers, the pubsub and logging system tests pass on Python3.4 with GAX enabled.

@tseaver
Re-enable GAX by default if it is importable.
46b21c9 
As of the '0.8.1' versions of the wrappers, the pubsub and logging
system tests pass on Python3.4 with GAX enabled.
@tseaver tseaver added api: pubsub Issues related to the Pub/Sub API. api: logging Issues related to the Cloud Logging API. grpc labels Aug 10, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 10, 2016
@dhermes
Copy link
Contributor

dhermes commented Aug 10, 2016

Do we need a docs change here?

@tseaver
Copy link
Contributor Author

tseaver commented Aug 10, 2016

Maybe so. We didn't previously document how to enable the GAX wrappers, as it was really a "developers only" option.

@tseaver
Copy link
Contributor Author

tseaver commented Aug 10, 2016 •
edited
Loading

@dhermes Docs added in 9cf5b72. PTAL

@dhermes
Copy link
Contributor

dhermes commented Aug 10, 2016

LGTM

@tseaver tseaver merged commit 27f0af5 into googleapis:master Aug 10, 2016
@tseaver tseaver deleted the reenable-gax-by-default branch August 10, 2016 21:24
This was referenced Aug 25, 2016
Closed
Closed
@dhermes dhermes mentioned this pull request Sep 19, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: logging Issues related to the Cloud Logging API. api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement. grpc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tseaver @dhermes @googlebot