Skip to content

Conversation

@dhermes
Copy link
Contributor

@dhermes dhermes commented Aug 23, 2016

Also

  • removing no longer needed toc-all.json
  • removing a section of toc.json in exceptions that didn't belong

Used the following script to update the content:

import json

files = [
    'docs/json/json/master/index.json',
    'docs/json/json/master/toc.json',
    'docs/json/manifest.json',
]

for filename in files:
    with open(filename, 'rb') as file_obj:
        content = json.load(file_obj)
    with open(filename, 'wb') as file_obj:
        json.dump(content, file_obj, indent=2, sort_keys=True,
                  separators=(',', ': '))  # Added separators later
        file_obj.write('\n')  # Added later

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 23, 2016
@daspecster
Copy link
Contributor

LGTM

@dhermes
Copy link
Contributor Author

dhermes commented Aug 23, 2016

@daspecster This will also break #2167, so I'll hold off on merging until you get it in 😉

Ping me though so I don't forget?

@daspecster
Copy link
Contributor

Ok yeah, just waiting on travis again... ⏳

@dhermes
Copy link
Contributor Author

dhermes commented Aug 23, 2016

Just rebased after #2167. Note that I added a newline to the end of each JSON file and also used custom json separators since by default a trailing space is used after the comma separator.

@daspecster
Copy link
Contributor

LGTM.

@dhermes dhermes merged commit 94c2743 into googleapis:master Aug 23, 2016
@dhermes dhermes deleted the update-toc-json branch August 23, 2016 22:37
@dhermes dhermes mentioned this pull request Sep 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants