-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating Bigtable stub creation to work with emulator. #2249
Conversation
I'll take a look |
Thanks! |
@garye I should note that only the last commit is germane to this PR, the rest are for the two diffbase PRs. |
@garye I have found the start of a culprit. Some operations accidentally kill the server, causing all subsequent operations to fail. Also the example stack trace refers to a path not on my machine (
|
@dhermes needs rebasing. |
49c6e7c
to
5000ac6
Compare
instances, failed_locations = retry(Config.CLIENT.list_instances)() | ||
|
||
if len(failed_locations) != 0: | ||
raise ValueError('List instances failed in module set up.') |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Would it be simpler to wrap the instance admin / table admin testsuite classes in |
The problem is that |
5000ac6
to
191c042
Compare
System test will be updated soon, once some issues with the emulator are worked out.
191c042
to
4191ebf
Compare
FWIW the AppVeyor check has been deleted (was created when messing around trying to create https://ci.appveyor.com/project/GoogleCloudPlatform/google-cloud-python/) |
@tseaver PTAL |
LGTM |
System test will be updated soon, once some issues with the emulator are worked out.
Message was previously:
Currently does not work as-is since most of the methods (most notable row.commit()) result in
UNAVAILABLE
from the backend.Towards #2242.
/cc @garye Could you check out this branch and run
tox -e bigtable-emulator
to see the failures?NOTE: Has #2245 as diffbase.