Switch back to Sphinx. #2267

daspecster · 2016-09-08T15:59:35Z

Switching back to Sphinx.

We will need to update the index.html on the gh-pages branch I believe to make this work.

@dhermes I'm not sure where the content for the index.html files in latest/ and stable/ get generated from. They have the wrong example code in them.

Testing: http://daspecster.github.io/google-cloud-python

googlebot · 2016-09-08T15:59:37Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

googlebot · 2016-09-08T16:03:39Z

CLAs look good, thanks!

scripts/get_version.py

+"""Simple script to get the gcloud version."""
+
+from pkg_resources import get_distribution
+print get_distribution('google-cloud').version


scripts/update_docs.sh

+GH_PAGES_DIR="ghpages"
+git submodule add -b gh-pages \
+    "https://${GH_OAUTH_TOKEN}@github.com/${GH_OWNER}/${GH_PROJECT_NAME}" \
+    ${GH_PAGES_DIR}


googlebot · 2016-09-08T16:58:19Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

googlebot · 2016-09-08T16:58:55Z

CLAs look good, thanks!

daspecster · 2016-09-08T19:16:49Z

That's weird, github timed out for appveyor?

Build started
git clone -q https://github.com/GoogleCloudPlatform/google-cloud-python.git C:\projects\google-cloud-python
git fetch -q origin +refs/pull/2267/merge:
fatal: unable to access 'https://github.com/GoogleCloudPlatform/google-cloud-python.git/': Failed to connect to github.com port 443: Timed out
Command exited with code 128

dhermes · 2016-09-08T19:24:42Z

Don't worry about going Green for AppVeyor on a PR. I turned that off earlier today (the default webhook setting is to send for a push to master AND on a PR, but I set it to just push).

daspecster · 2016-09-08T19:28:17Z

OK thanks! Let me know if this looks good to you.

scripts/update_docs.sh

+    # Also update the versions file.
+    ../.tox/docs/bin/python ../scripts/update_versions.py
+    # Update the files which were updated in the release.
+    git add versions.html versions.json


dhermes · 2016-09-08T19:50:29Z

Remove all versions related files, since they aren't used by the template. (See my comment in-line in the bash script.)

dhermes · 2016-09-08T20:09:46Z

LGTM pending Travis. Squash commits if you please?

googlebot · 2016-09-08T20:11:13Z

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

googlebot · 2016-09-08T20:12:36Z

CLAs look good, thanks!

dhermes · 2016-09-08T20:16:48Z

Is the CLA bot busted? Keeps weighing in when you'd expect it to be happy already

theacodes · 2016-09-08T20:17:59Z

It rechecks whenever a push or comment occurs.

On Thu, Sep 8, 2016, 1:16 PM Danny Hermes notifications@github.com wrote:

Is the CLA bot busted? Keeps weighing in when you'd expect it to be happy
already

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#2267 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAPUc67dhUoq4Ni__0Yl4vgvWyZJA-ysks5qoG0xgaJpZM4J4KUC
.

daspecster · 2016-09-08T20:19:35Z

So there's a few things happening. Whenever I run the update_docs.sh script, it overwrites my global git user and I forget to switch it back.
Then this last time I didn't realize I had to rebase, so there were both Tres's commits and mine in this PR. I rebased and it was all set.

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>

daspecster added the docs label Sep 8, 2016

daspecster assigned dhermes Sep 8, 2016

googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Sep 8, 2016

daspecster force-pushed the switch-to-sphinx branch from ad6c065 to 5b435a9 Compare September 8, 2016 16:03

googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Sep 8, 2016

dhermes reviewed Sep 8, 2016
View reviewed changes

scripts/get_version.py Outdated

"""Simple script to get the gcloud version."""

from pkg_resources import get_distribution

print get_distribution('google-cloud').version

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

daspecster mentioned this pull request Sep 8, 2016

Updates for rename #2268

Closed

dhermes reviewed Sep 8, 2016
View reviewed changes

scripts/update_docs.sh

GH_PAGES_DIR="ghpages"

git submodule add -b gh-pages \

"https://${GH_OAUTH_TOKEN}@github.com/${GH_OWNER}/${GH_PROJECT_NAME}" \

${GH_PAGES_DIR}

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Sep 8, 2016

daspecster force-pushed the switch-to-sphinx branch from 15aa2fb to 4d2d64c Compare September 8, 2016 16:58

googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Sep 8, 2016

daspecster force-pushed the switch-to-sphinx branch from cdf61fb to 8fa007d Compare September 8, 2016 18:27

dhermes reviewed Sep 8, 2016
View reviewed changes

scripts/update_docs.sh Outdated

# Also update the versions file.

../.tox/docs/bin/python ../scripts/update_versions.py

# Update the files which were updated in the release.

git add versions.html versions.json

This comment was marked as spam.

Sign in to view

daspecster force-pushed the switch-to-sphinx branch from f86dac6 to a177e3b Compare September 8, 2016 20:11

googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Sep 8, 2016

Switch back to Sphinx.

9d8a26e

daspecster force-pushed the switch-to-sphinx branch from a177e3b to 9d8a26e Compare September 8, 2016 20:12

googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Sep 8, 2016

daspecster merged commit e553ddd into googleapis:master Sep 8, 2016

This was referenced Sep 16, 2016

[Documentation Issue] Links to previous versions are missing. #2073

Closed

Module level doc strings are sparse / all contained in usage docs #2159

Closed

Usage docs and other prose in RST files not included in docs #2194

Closed

dhermes mentioned this pull request Sep 19, 2016

Cut 0.19.0 release. #2270

Merged

daspecster deleted the switch-to-sphinx branch January 24, 2017 15:19

theacodes unassigned dhermes Sep 28, 2018

parthea added a commit that referenced this pull request Nov 24, 2025

chore(deps): update all dependencies (#2267)

96f1810

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>

Switch back to Sphinx. #2267

Switch back to Sphinx. #2267

Uh oh!

Conversation

daspecster commented Sep 8, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

googlebot commented Sep 8, 2016

Uh oh!

googlebot commented Sep 8, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

googlebot commented Sep 8, 2016

Uh oh!

googlebot commented Sep 8, 2016

Uh oh!

daspecster commented Sep 8, 2016

Uh oh!

dhermes commented Sep 8, 2016

Uh oh!

daspecster commented Sep 8, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

dhermes commented Sep 8, 2016

Uh oh!

dhermes commented Sep 8, 2016

Uh oh!

googlebot commented Sep 8, 2016

Uh oh!

googlebot commented Sep 8, 2016

Uh oh!

dhermes commented Sep 8, 2016

Uh oh!

theacodes commented Sep 8, 2016

Uh oh!

daspecster commented Sep 8, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

daspecster commented Sep 8, 2016 •

edited

Loading