-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove gRPC/GAX conditional checks. #2308
Conversation
I also added this branch to https://github.com/GoogleCloudPlatform/google-cloud-python/ temporarily to vet the AppVeyor changes: |
What's prompting this change? This is essentially switching to grpc as a hard requirement for this library. @omaray should probably chime in, too. |
@jonparrott I touched an old part in #2304 that sparked the discussion. gRPC is already a hard requirement in Python 2.7. Very soon it won't be in I just wanted your input on the env. var. to shut it down. |
Any dynamic behavior in setup.py will force you to stop providing wheels Otherwise whatever. App engine standard really just needs to add grpc On Mon, Sep 12, 2016, 6:33 PM Danny Hermes notifications@github.com wrote:
|
How so? |
Wheels don't run setup.py at all. On Mon, Sep 12, 2016, 6:40 PM Danny Hermes notifications@github.com wrote:
|
@jonparrott So your concern is that Worth noting: I canceled the |
@dhermes exactly |
But for the purposes of you writing docs, couldn't you include This discussion may become moot when we make each service it's own package? But for services like Any suggestions for how to play nice with everyone (GAE, using wheels, etc.)? |
Just be sure to publish an sdist as well as a wheel for now. I really have no idea what our strategy is going to be for standard. |
@jonparrott SGTM, I'll tear out the env. var. and we can punt for now. |
57c2dbc
to
979dd17
Compare
I deleted the branch and AppVeyor didn't trigger on my new push w/o the GAE env. var. https://ci.appveyor.com/project/GoogleCloudPlatform/google-cloud-python/build/1.0.664.followup-2304 still a good indicator that the changes work on Windows |
@tseaver PTAL |
@@ -28,8 +28,9 @@ | |||
'grpc-google-logging-v2 >= 0.8.0, < 0.9dev', | |||
] | |||
|
|||
if sys.version_info[:2] == (2, 7) and 'READTHEDOCS' not in os.environ: | |||
REQUIREMENTS.extend(GRPC_EXTRAS) | |||
RTD_ENV_VAR = 'READTHEDOCS' |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
I'm confused: aren't we losing our can't-install-gRPC fallback here? |
979dd17
to
27a6c42
Compare
@tseaver What is our "our can't-install-gRPC fallback"? |
@dhermes Until this PR, installing With this change, users who cannot install |
|
@tseaver Bump. |
LGTM. I'll let @jonparrott deal with the pitchfork-wielding GAE mob, then. :) |
Adding support for an environment variable that App Engine users can use to disable installing gRPC packages into their application.Follow-up to #2304.
@jonparrott Can you weigh in here on the GAE env. var. in
setup.py
?