Skip to content

Conversation

@dhermes
Copy link
Contributor

@dhermes dhermes commented Sep 13, 2016

As with #2307, I took down a bunch of failures last week and can't track down where this occurred, sorry.

@dhermes dhermes added api: storage Issues related to the Cloud Storage API. testing api: bigquery Issues related to the BigQuery API. flaky labels Sep 13, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 13, 2016
@dhermes
Copy link
Contributor Author

dhermes commented Sep 13, 2016

I'm not sure if we should check more than 409, there isn't much in the error:

>>> print(json.dumps(exc._errors, indent=2))
[
  {
    "domain": "global",
    "message": "The bucket you tried to delete was not empty.",
    "reason": "conflict"
  }
]
>>> exc.message
u'The bucket you tried to delete was not empty. (DELETE https://www.googleapis.com/storage/v1/b/{BUCKET})'

@daspecster
Copy link
Contributor

409 could in theory...have many different messages attached to it.

Could we retry but also log/print the message incase it changes?

@daspecster
Copy link
Contributor

Otherwise LGTM if you don't think we should log it.

@dhermes
Copy link
Contributor Author

dhermes commented Sep 13, 2016

Could we retry but also log/print the message incase it changes?

Sure, but we wouldn't see it on CI, unless it failed.

I've been meaning to make the GoogleCloudError representation more verbose so we get more info.

@tseaver
Copy link
Contributor

tseaver commented Sep 14, 2016

LGTM

@dhermes dhermes merged commit 1f7ed9d into googleapis:master Sep 15, 2016
@dhermes dhermes deleted the bigquery-409-bucket-delete branch September 15, 2016 00:09
@dhermes dhermes mentioned this pull request Sep 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the BigQuery API. api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement. testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants