Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a system test for 'Table.upload_from_file'. #2313

Merged
merged 3 commits into from
Sep 15, 2016
Merged

Add a system test for 'Table.upload_from_file'. #2313

merged 3 commits into from
Sep 15, 2016

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Sep 13, 2016

Closes #2133.

/cc @jonparrott, @matheuspatury

I will cancel the PR job on Travis, as this PR changes only system tests.

@tseaver tseaver added testing api: bigquery Issues related to the BigQuery API. labels Sep 13, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 13, 2016
@tseaver
Copy link
Contributor Author

tseaver commented Sep 13, 2016

@jgeewax, @omaray the new system test passes, and shows correct usage of Table.upload_from_file.

@dhermes
Copy link
Contributor

dhermes commented Sep 13, 2016

Before reviewing, this doesn't seem to fix the title of the issue:

bigquery.table.Table.upload_from_file fails with 400

Should the issue be renamed to be more accurate?

dhermes
dhermes reviewed Sep 13, 2016
View reviewed changes
system_tests/bigquery.py
writer.writerows(ROWS)
csv_file.flush()

with open(csv_file.name, 'rb') as csv_read:

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@tseaver
Copy link
Contributor Author

tseaver commented Sep 14, 2016

Before reviewing, this doesn't seem to fix the title of the issue: "bigquery.table.Table.upload_from_file fails with 400"

The OP in that issue made an understandable error, calling job.begin() on the job returned from table.upload_from_file(): the issue is that the job already started, and the resource returned for the job does not contain enough information to (re)start it. This PR just demonstrates that table.upload_from_file() works as expected without making that call.

Should the issue be renamed to be more accurate?

We could rename the issue, or just close it and move on.

@dhermes
Copy link
Contributor

dhermes commented Sep 14, 2016

We could rename the issue, or just close it and move on.

Can you rename it to be more accurate? This way if anyone comes across it again they won't be misled.

@tseaver
Copy link
Contributor Author

tseaver commented Sep 14, 2016

Renamed.

@tseaver tseaver mentioned this pull request Sep 14, 2016
Closed
@tseaver
Add a system test for 'Table.upload_from_file'.
e5fa350 
Closes #2133.
@tseaver
Add note to 'Table.upload_from_file' docstring.
dcc0779 
Highlight that the returned job is already running, and that the user
should not call its 'begin' method.
@tseaver
Raise ValueError from 'Job.begin' if already running.
5ebd09a
@dhermes
Copy link
Contributor

dhermes commented Sep 15, 2016

LGTM

@tseaver
Copy link
Contributor Author

tseaver commented Sep 15, 2016

@dhermes Any remaining issues?

dhermes
dhermes approved these changes Sep 15, 2016
View reviewed changes
Copy link
Contributor

@dhermes dhermes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tseaver tseaver merged commit d861610 into googleapis:master Sep 15, 2016
@tseaver tseaver deleted the 2133-bigquery-systest-table-upload_from_file branch September 15, 2016 16:13
@dhermes dhermes mentioned this pull request Sep 19, 2016
Merged
parthea pushed a commit that referenced this pull request Sep 22, 2023
@anguillanneuf @danoscarmike
[video] Streaming AutoML Classification [(#2313)](GoogleCloudPlatform…
d4efaaa 
…/python-docs-samples#2313)

* Video Intelligence Beta - Streaming/Live Streaming support for AutoML custom models

* add test skeleton

* skeleton

* more skeleton code

* update sample: update video codec/test/model_id/etc.

* lint

* mask project id

* Noah's and Rebecca's suggestions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhermes dhermes dhermes approved these changes

Assignees
No one assigned
Labels
api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement. testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tseaver @dhermes @daspecster @googlebot