Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support entity protobufs #232

Merged
merged 10 commits into from
Oct 9, 2014
Merged

Support entity protobufs #232

merged 10 commits into from
Oct 9, 2014

Commits on Oct 9, 2014

  1. Add explicit support for 'entity_value' in protobufs.

    @tseaver
    tseaver committed Oct 9, 2014
    Configuration menu
    Copy the full SHA
    1a79c89 View commit details
    Browse the repository at this point in the history

  2. Lint removal.

    @tseaver
    tseaver committed Oct 9, 2014
    Configuration menu
    Copy the full SHA
    e5954fc View commit details
    Browse the repository at this point in the history

  3. Add helpers.set_protobuf_value. 

    Handles compount fields (entity, key) not assignable via setattr.
    @tseaver
    tseaver committed Oct 9, 2014
    Configuration menu
    Copy the full SHA
    c8f9a7a View commit details
    Browse the repository at this point in the history

  4. Use helpers.set_protobuf_value to support composite types.

    @tseaver
    tseaver committed Oct 9, 2014
    Configuration menu
    Copy the full SHA
    37304c9 View commit details
    Browse the repository at this point in the history

  5. Fix docstring param name. 

    Incorporates feedback from @dhermes.
    @tseaver
    tseaver committed Oct 9, 2014
    Configuration menu
    Copy the full SHA
    f5ee0d7 View commit details
    Browse the repository at this point in the history

  6. Drop XXX comment. 

    Entities are not required to have datasets w/ active connections.
    @tseaver
    tseaver committed Oct 9, 2014
    Configuration menu
    Copy the full SHA
    8fe4168 View commit details
    Browse the repository at this point in the history

  7. Don't set default key on entity protobuf if entity has no key. 

    Incorporates feedback from @dhermes.
    @tseaver
    tseaver committed Oct 9, 2014
    Configuration menu
    Copy the full SHA
    1679154 View commit details
    Browse the repository at this point in the history

  8. Rename helper functions with leading underscore. 

    Signal that they are *not* part of the gcloud-python API.
    @tseaver
    tseaver committed Oct 9, 2014
    Configuration menu
    Copy the full SHA
    49f04b5 View commit details
    Browse the repository at this point in the history

  9. Update doctring to indicate that helper functions are not API. 

    Note that these are functions, not methods.
    @tseaver
    tseaver committed Oct 9, 2014
    Configuration menu
    Copy the full SHA
    275f6bd View commit details
    Browse the repository at this point in the history

  10. Rename datastore.helpers -> _helpers. 

    Further emphasize non-API nature.
    @tseaver
    tseaver committed Oct 9, 2014
    Configuration menu
    Copy the full SHA
    fef83a1 View commit details
    Browse the repository at this point in the history