Skip to content

Ensure that 'QueryResults.from_query_job' copies 'job.name'. #2378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tseaver merged 1 commit into from
Sep 21, 2016
Merged

Ensure that 'QueryResults.from_query_job' copies 'job.name'. #2378

tseaver merged 1 commit into from
Sep 21, 2016

Conversation

@tseaver
Copy link
Contributor

@tseaver tseaver commented Sep 21, 2016

Closes #2368.

@tseaver tseaver added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. api: bigquery Issues related to the BigQuery API. labels Sep 21, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 21, 2016
dhermes
dhermes approved these changes Sep 21, 2016
View reviewed changes
Copy link
Contributor

@dhermes dhermes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending Travis

@tseaver tseaver merged commit 5b6631a into googleapis:master Sep 21, 2016
@tseaver tseaver deleted the 2368-bigquery-async_query_job-results branch September 21, 2016 20:40
parthea pushed a commit that referenced this pull request Sep 22, 2023
@crowdus @busunkim96
fix: MP3 file test for Text-to-Speech SSML addresses [(#2378)](Google…
2a5e254 
…CloudPlatform/python-docs-samples#2378)

* fix: refactored MP3 file tests

* fix: moving resources to cloud-client/resources

* fix: removing expected_example.mp3
parthea pushed a commit that referenced this pull request Sep 22, 2023
@crowdus @busunkim96
fix: MP3 file test for Text-to-Speech SSML addresses [(#2378)](Google…
7eb8719 
…CloudPlatform/python-docs-samples#2378)

* fix: refactored MP3 file tests

* fix: moving resources to cloud-client/resources

* fix: removing expected_example.mp3
parthea added a commit that referenced this pull request Nov 24, 2025
@parthea
chore: update generated MANIFEST.in (#2378)
46fb986
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dhermes dhermes dhermes approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tseaver @dhermes @daspecster @googlebot