Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'Blob.rewrite' API wrapper method. #2510

Merged
merged 1 commit into from
Oct 11, 2016
Merged

Add 'Blob.rewrite' API wrapper method. #2510

merged 1 commit into from
Oct 11, 2016

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Oct 6, 2016

Uses #2507 as a base.

NOTE: New system tests cannot be exercised until #2509 is merged.

Closes: #1960.

/cc @jonparrott

@tseaver tseaver added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. api: storage Issues related to the Cloud Storage API. do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Oct 6, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 6, 2016
@tseaver tseaver removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 10, 2016
if api_response['done']:
return None, rewritten, size

return api_response['rewriteToken'], rewritten, size

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

@dhermes
Copy link
Contributor

dhermes commented Oct 11, 2016

LGTM

@tseaver tseaver merged commit afcafd8 into googleapis:master Oct 11, 2016
@tseaver tseaver deleted the 1960-storage-blob_rewrite branch October 11, 2016 20:05
richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017
…rite

Add 'Blob.rewrite' API wrapper method.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants