Removing Iterator and Page subclasses. #2558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
@dhermes the general idea here LGTM. |
|
@tseaver PTAL. I'd really like to get the |
Instead require `Iterator` takes: - a well-formed path for the request - a callable to convert a JSON item to native obj. - (optional) the key in a response holding all items - (optional) a `page_start` (acts as proxy for `Page.__init__`)
dhermes
force-pushed
the
no-more-iterator-subclasses
branch
from
db650b7
to
8cc9341
Compare
This was referenced Oct 18, 2016
|
Ditto @jonparrott. |
tseaver
reviewed
Oct 18, 2016
| :param item_to_value: (Optional) Callable to convert an item from JSON | ||
| into the native object. Assumed signature | ||
| takes an :class:`Iterator` and a dictionary | ||
| holding a single item. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
|
||
| :type items_key: str | ||
| :param items_key: The key used to grab retrieved items from an API | ||
| response. Defaults to :data:`DEFAULT_ITEMS_KEY`. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
@tseaver Anything else? |
|
@tseaver So I'll add "(Optional)" to the docstring and make Good to merge after those changes are in? |
Yup. |
Also adding "(Optional)" to items_key docstring.
|
OK, waited an hour for Travis. Merging. (There is a lot to do after.) |
richkadel
pushed a commit
to richkadel/google-cloud-python
that referenced
this pull request
May 6, 2017
…lasses Removing Iterator and Page subclasses.
parthea
pushed a commit
that referenced
this pull request
Jun 4, 2023
Removing Iterator and Page subclasses.
parthea
pushed a commit
that referenced
this pull request
Oct 21, 2023
…](GoogleCloudPlatform/python-docs-samples#2558) * fix: Use different versions of pytest for python 2 and python3 * fix: delete extra pytest dep * fix: update pytest dependencies in requirements.txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead require
Iteratortakes:page_start(acts as proxy forPage.__init__)