-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Google Cloud Storage bucket classes. #2571
Conversation
refresh 10/20
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I work at google (yyzhang@google.com). please grant me cla. thanks |
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
@y33zhang for CLA bot to recognize you, you need to register your github username at go/github and use your @google.com address to author your commits. |
ahh, noob github user here ;). Is there a way to retroactively set my google.com address on previous commits? |
@y33zhang, yeah you can |
@daspecster thanks a lot, just amended the commit email address. Is there anything else I need to do to get past the cla check? |
@@ -842,6 +842,27 @@ def test_storage_class_setter_NEARLINE(self): | |||
self.assertEqual(bucket.storage_class, 'NEARLINE') | |||
self.assertTrue('storageClass' in bucket._changes) | |||
|
|||
def test_storage_class_setter_COLDINE(self): |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Well that was easy! LGTM modulo the misspelling. We can merge over the CLA-bot issue. |
I couldn't find those new types in the API docs? |
fix spelling
@daspecster - those are getting updated later today |
@dhermes - still can't get cla check to pass. can you help merge over the cla issue? thanks! |
@dhermes - can you help provide an ETA on when the docs will be refreshed/updated on the live site? Thanks! |
https://googlecloudplatform.github.io/google-cloud-python/latest/storage-buckets.html#google.cloud.storage.bucket.Bucket.storage_class You just made me realize that readthedocs.org is not picking up the correct version (probably due to dependency caching). When I fix that the RTD docs will also be updated at: http://google-cloud-python.readthedocs.io/en/latest/storage-buckets.html Just because the docs are updated doesn't mean the |
Update Google Cloud Storage bucket classes.
product refresh