Using absolute imports in core modules that import grpc. #2632
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is because a relative import (in Python 2.7) was causing failures when
google.cloud.grpc
was side-by-side withgoogle.cloud._helpers
, etc.For example, see the failure: https://travis-ci.org/GoogleCloudPlatform/google-cloud-python/builds/171149390#L1738-L1750
FYI @geigerj @bjwatson
To repro (before this PR):