Adding basic CircleCI configuration. #2701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
dhermes
force-pushed
the
add-circleci-config
branch
2 times, most recently
from
2b9626b to
aacd2e1
Compare
dhermes
force-pushed
the
add-circleci-config
branch
from
2fccf32 to
8576e49
Compare
|
Bump! All our PR builds are red right now. Is there a way we could just run both to get this in and then maybe bring up dropping travis if we're happy with circleci? |
|
This is failing to upload to coveralls.io for some reason. From the first successful merge build: |
|
Turns out I had to manually add the repo token: https://circleci.com/docs/code-coverage/#coveralls Done via https://circleci.com/gh/GoogleCloudPlatform/google-cloud-python/edit#env-vars |
richkadel
pushed a commit
to richkadel/google-cloud-python
that referenced
this pull request
May 6, 2017
Adding basic CircleCI configuration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying out CircleCI in earnest since Travis throttles us every day.
Most of our tooling is Travis centric, so this alone is insufficient, but it's worth seeing if we can at least go green on Circle CI.
I have been working on https://github.com/dhermes/ci-diff-helper in the last few weeks, so hopefully I can factor out our Travis-dependent code and replace it with more generic "help me in any CI" code.
/cc @omaray @jgeewax @jonparrott