Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make annotation constants private. #2779

Merged
merged 1 commit into from
Nov 30, 2016
Merged

Make annotation constants private. #2779

merged 1 commit into from
Nov 30, 2016

Conversation

daspecster
Copy link
Contributor

Missed from #2770.

@daspecster daspecster added the api: vision Issues related to the Cloud Vision API. label Nov 30, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 30, 2016
@daspecster daspecster mentioned this pull request Nov 30, 2016
Merged
dhermes
dhermes approved these changes Nov 30, 2016
View reviewed changes
Copy link
Contributor

@dhermes dhermes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (in the future, feel free to merge first and ask questions later on PRs like this)

@daspecster
Copy link
Contributor Author

Thanks!

@daspecster daspecster merged commit 51c2cf3 into googleapis:master Nov 30, 2016
@daspecster daspecster deleted the make-annotation-constants-private branch November 30, 2016 05:16
richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017
@daspecster
Merge pull request googleapis#2779 from daspecster/make-annotation-co…
b9b2c81 
…nstants-private

Make annotation constants private.
parthea pushed a commit that referenced this pull request Oct 21, 2023
@daspecster
Merge pull request #2779 from daspecster/make-annotation-constants-pr…
ff51602 
…ivate

Make annotation constants private.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhermes dhermes dhermes approved these changes

Assignees
No one assigned
Labels
api: vision Issues related to the Cloud Vision API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daspecster @dhermes @googlebot